]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
messageTray: Take modal grabs for the context menu and notification boxpointer
authorJasper St. Pierre <jstpierre@mecheye.net>
Thu, 21 Mar 2013 19:29:16 +0000 (15:29 -0400)
committerJasper St. Pierre <jstpierre@mecheye.net>
Tue, 23 Apr 2013 20:33:13 +0000 (16:33 -0400)
As the context menu and notification boxpointer can only appear if we already
take a modal grab, grabFocus will have problematic results if the focus does
somehow change.

https://bugzilla.gnome.org/show_bug.cgi?id=698483

js/ui/messageTray.js

index 70ff6d2d10510864e1d2ec681eb95e1747c6d8fe..c9e64e7f83eb09c02d0a947888ccc69628f6d319 100644 (file)
@@ -1748,7 +1748,7 @@ const MessageTray = new Lang.Class({
         let [x, y, mask] = global.get_pointer();
         this._contextMenu.setPosition(Math.round(x), Math.round(y));
         this._grabHelper.grab({ actor: this._contextMenu.actor,
-                                grabFocus: true,
+                                modal: true,
                                 onUngrab: Lang.bind(this, function () {
                                     this._contextMenu.close(BoxPointer.PopupAnimation.FULL);
                                 })
@@ -2661,7 +2661,7 @@ const MessageTray = new Lang.Class({
         }
 
         this._grabHelper.grab({ actor: this._summaryBoxPointer.bin.child,
-                                grabFocus: true,
+                                modal: true,
                                 onUngrab: Lang.bind(this, this._onSummaryBoxPointerUngrabbed) });
 
         this._summaryBoxPointer.actor.opacity = 0;